Fix pod summary for large numbers of pods #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a bug which caused clusters with more than 500 pods to fail pod summary step. The code assumed that if result.Infos had more than one element, the k8s request returned more than 1 resource type which is not correct for a table. The result specifies pods as a resource type, so the assumption was wrong. Multiple Infos objects resulted from client dividing requests into chunks, as specified by RequestChunksOf function on request builder. The change merges all Info objects into one table and returns it. Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
nebril
force-pushed
the
pr/nebril/fix-k8s-pods-table
branch
from
d57e1b0
to
9b5c954
Compare
joamaki
approved these changes
Jul 12, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
Nice catch! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug which caused clusters with more than 500 pods to fail pod summary step.
The code assumed that if result.Infos had more than one element, the k8s request returned more than 1 resource type which is not correct for a table.
The result specifies pods as a resource type, so the assumption was wrong. Multiple Infos objects resulted from client dividing requests into chunks, as specified by RequestChunksOf function on request builder.
The change merges all Info objects into one table and returns it.
fixes: #905