-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kind: Configure external targets inside the cluster #1846
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
force-pushed
the
pr/michi/final-external-target
branch
from
July 18, 2023 17:15
dac928c
to
a290c91
Compare
michi-covalent
force-pushed
the
pr/michi/final-external-target
branch
from
July 18, 2023 17:27
a290c91
to
91a84c0
Compare
michi-covalent
force-pushed
the
pr/michi/final-external-target
branch
from
July 18, 2023 17:59
91a84c0
to
4fdead9
Compare
michi-covalent
force-pushed
the
pr/michi/final-external-target
branch
from
July 18, 2023 18:11
4fdead9
to
228b9ce
Compare
michi-covalent
force-pushed
the
pr/michi/final-external-target
branch
from
July 18, 2023 20:30
228b9ce
to
825fb2c
Compare
to test locally:
|
michi-covalent
force-pushed
the
pr/michi/final-external-target
branch
from
July 18, 2023 20:38
825fb2c
to
58b4515
Compare
Add --external-target-ca-{name,namespace} flags to "connectivity test" command to specify the external target CA for client-egress-l7-tls test cases. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Ignore "Unable to find identity of previously used CIDR" error message. Cilium versions 1.13 and older log this error message when the CIDR range specified with --external-cidr flag overlaps with the node IP range. See cilium/cilium#26881 for additional details. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/final-external-target
branch
from
July 18, 2023 21:23
58b4515
to
e1c003d
Compare
michi-covalent
force-pushed
the
pr/michi/final-external-target
branch
from
July 18, 2023 21:26
e1c003d
to
d05c9f0
Compare
There are 2 nodes without Cilium installed in this configuration. Use these nodes as the external targets for both DNS and CIDR-based test cases to avoid depending on external services like one.one.one.one. Ref: #1720 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/final-external-target
branch
from
July 18, 2023 21:39
d05c9f0
to
5dcec89
Compare
michi-covalent
changed the title
Pr/michi/final external target
kind: Configure external targets inside the cluster
Jul 18, 2023
sayboras
approved these changes
Jul 18, 2023
squeed
approved these changes
Jul 19, 2023
nbusseneau
approved these changes
Jul 19, 2023
learnitall
approved these changes
Jul 19, 2023
alright i'm shipping this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 commits:
--external-target-ca-{name,namespace}
flags to override CA bundle secret for client-egress-l7-tls tests.reserved:world
and cilium node CIDR ranges overlap cilium#26881 for details.