connectivity: Fix fetching of XFRM counters #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it was failing with:
[-] Scenario [no-ipsec-xfrm-errors/no-ipsec-xfrm-error]
No cilium pods found
Fixes: e656f58 ("connectivity: add xfrm error check for IPsec conn disrupt test")
Signed-off-by: Martynas Pumputis <m@lambda.lt>
pchaigno
approved these changes
Jul 21, 2023
brb
added
the
ready-to-merge
brb
added a commit
to cilium/cilium
that referenced
this pull request
Aug 3, 2023
cilium/cilium-cli#1854 is released. Signed-off-by: Martynas Pumputis <m@lambda.lt>
jschwinger233
added a commit
to jschwinger233/cilium-cli
that referenced
this pull request
Aug 4, 2023
Previously we tried to get it via PodStatus.NominatedNodeName, which is usually set to empty. Fixes: cilium#1854 Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
jschwinger233
added a commit
to jschwinger233/cilium-cli
that referenced
this pull request
Aug 7, 2023
Previously we tried to get it via PodStatus.NominatedNodeName, which is usually set to empty. According to the [doc](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#user-exposed-information), nominatedNodeName is set only if preemption takes place, and a pod is not necessarily scheduled to the nominatedNodeName. This commit therefore uses nodeName of Pod spec instead. Fixes: cilium#1854 Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
jschwinger233
added a commit
to jschwinger233/cilium-cli
that referenced
this pull request
Aug 8, 2023
Previously we tried to get a pod's nodename via PodStatus.NominatedNodeName, which is usually set to empty. According to the [doc](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#user-exposed-information), nominatedNodeName is set only if preemption takes place, and a pod is not necessarily scheduled to the nominatedNodeName. This commit therefore uses the HostIP from pod status. Fixes: cilium#1854 Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
jschwinger233
added a commit
to jschwinger233/cilium-cli
that referenced
this pull request
Aug 8, 2023
Previously we tried to get a pod's nodename via PodStatus.NominatedNodeName, which is usually set to empty. According to the [doc](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#user-exposed-information), nominatedNodeName is set only if preemption takes place, and a pod is not necessarily scheduled to the nominatedNodeName. This commit therefore uses the HostIP from pod status. Fixes: cilium#1854 Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
aanm
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 9, 2023
cilium/cilium-cli#1854 is released. Signed-off-by: Martynas Pumputis <m@lambda.lt>
joamaki
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 9, 2023
[ upstream commit 4461616 ] cilium/cilium-cli#1854 is released. Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Jussi Maki <jussi@isovalent.com>
joamaki
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 9, 2023
[ upstream commit 4461616 ] cilium/cilium-cli#1854 is released. Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Jussi Maki <jussi@isovalent.com>
tklauser
pushed a commit
that referenced
this pull request
Aug 9, 2023
Previously we tried to get a pod's nodename via PodStatus.NominatedNodeName, which is usually set to empty. According to the [doc](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#user-exposed-information), nominatedNodeName is set only if preemption takes place, and a pod is not necessarily scheduled to the nominatedNodeName. This commit therefore uses the HostIP from pod status. Fixes: #1854 Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
joamaki
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 10, 2023
[ upstream commit 4461616 ] cilium/cilium-cli#1854 is released. Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Jussi Maki <jussi@isovalent.com>
YutaroHayakawa
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 15, 2023
[ upstream commit 4461616 ] cilium/cilium-cli#1854 is released. Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Jussi Maki <jussi@isovalent.com>
aanm
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 16, 2023
[ upstream commit 4461616 ] cilium/cilium-cli#1854 is released. Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Jussi Maki <jussi@isovalent.com>
ti-mo
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 17, 2023
[ upstream commit 4461616 ] cilium/cilium-cli#1854 is released. Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Jussi Maki <jussi@isovalent.com>
tklauser
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 24, 2023
[ upstream commit 4461616 ] cilium/cilium-cli#1854 is released. Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 25, 2023
[ upstream commit 4461616 ] cilium/cilium-cli#1854 is released. Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
joestringer
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 25, 2023
[ upstream commit 4461616 ] cilium/cilium-cli#1854 is released. Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was failing with:
Fixes: e656f58 ("connectivity: add xfrm error check for IPsec conn disrupt test")