Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renovate: Don't update golang.org/x/exp #1885

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

michi-covalent
Copy link
Contributor

v0.0.0-20230801115018-d63ba01acd4b causes this complilation error:

# github.com/cilium/cilium/pkg/hive/cell
Error: vendor/github.com/cilium/cilium/pkg/hive/cell/health.go:194:23:
type func(a Status, b Status) bool of func(a, b Status) bool {…} does not match inferred
type func(a Status, b Status) int for func(a E, b E) int

Ref: https://github.com/cilium/cilium-cli/actions/runs/5732604742/job/15535855918?pr=1873

v0.0.0-20230801115018-d63ba01acd4b causes this complilation error:

    # github.com/cilium/cilium/pkg/hive/cell
    Error: vendor/github.com/cilium/cilium/pkg/hive/cell/health.go:194:23:
    type func(a Status, b Status) bool of func(a, b Status) bool {…} does not match inferred
    type func(a Status, b Status) int for func(a E, b E) int

Ref: https://github.com/cilium/cilium-cli/actions/runs/5732604742/job/15535855918?pr=1873

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent requested a review from a team as a code owner August 1, 2023 23:14
@michi-covalent michi-covalent temporarily deployed to ci August 1, 2023 23:14 — with GitHub Actions Inactive
@michi-covalent
Copy link
Contributor Author

trying to make #1873 happy

@michi-covalent michi-covalent added the priority/release-blocker This issue will prevent the release of the next version of Cilium. label Aug 2, 2023
@michi-covalent
Copy link
Contributor Author

ok let's merge this and see

@michi-covalent michi-covalent merged commit 4904198 into main Aug 2, 2023
19 checks passed
@michi-covalent michi-covalent deleted the pr/michi/renovate branch August 2, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue will prevent the release of the next version of Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants