connectivity: Add secondary network NodePort tests #1942
Conversation
First, this commit introduces "--secondary-network-iface" flag. The flag is used to determine a secondary network IP addr of each node. Second, the commit extends the NodePort from outside tests. When the aforementioned flag is set, in addition to the regular curl request, the test case sends HTTP requests to an IP addr on each Cilium node which is set to the "--secondary-network-face". Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
added
the
ready-to-merge
|
The Go build error is a red-herring. Got review from Chris (:broccoli:), marking as ready to merge to unblock the e2e testing of Cilium's multi-dev changes. |
| if err != nil { | ||
| return fmt.Errorf("failed to fetch secondary network ip addr: %w", err) | ||
| } | ||
| ct.secondaryNetworkNodeIPv4[pod.Spec.NodeName] = strings.TrimSuffix(addr.String(), "\n") |
There was a problem hiding this comment.
Do we care to check if the returned address is somehow not set?
There was a problem hiding this comment.
Such a case should eventually become visible in the tests, but will make it more explicit 👍
Merged per this comment. |
Merging this PR with this Go build error in place makes this job fail consistently on |
This will enable secondary NodePort tests [1]. [1]: cilium/cilium-cli#1942 Signed-off-by: Martynas Pumputis <m@lambda.lt>
This will enable secondary NodePort tests [1]. [1]: cilium/cilium-cli#1942 Signed-off-by: Martynas Pumputis <m@lambda.lt>
[ upstream commit 814036b ] This will enable secondary NodePort tests [1]. [1]: cilium/cilium-cli#1942 Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Gilberto Bertin <jibi@cilium.io>
[ upstream commit 814036b ] This will enable secondary NodePort tests [1]. [1]: cilium/cilium-cli#1942 Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Gilberto Bertin <jibi@cilium.io>
First, this commit introduces "--secondary-network-iface" flag. The flag is used to determine a secondary network IP addr of each node.
Second, the commit extends the NodePort from outside tests. When the aforementioned flag is set, in addition to the regular curl request, the test case sends HTTP requests to an IP addr on each Cilium node which is set to the "--secondary-network-face".
Testing PR cilium/cilium#27738 (https://github.com/cilium/cilium/actions/runs/6010840377/job/16303159003)
cc @julianwiedmann @borkmann