tests: egressgw: minor improvements and clean ups #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jibi
force-pushed
the
pr/jibi/egressgw-cli-tests-improv
branch
from
d187988
to
d5e1cb1
Compare
jibi
force-pushed
the
pr/jibi/egressgw-cli-tests-improv
branch
from
d5e1cb1
to
3c8b316
Compare
jschwinger233
approved these changes
Jan 5, 2024
to better document how the ExcludedCIDRs param of CiliumEgressGatewayPolicyParams works Signed-off-by: Gilberto Bertin <jibi@cilium.io>
add a new PodSelectorKind parameter to CiliumEgressGatewayPolicyParams, which allows to select the pod matching the "kind" label Signed-off-by: Gilberto Bertin <jibi@cilium.io>
As CiliumEgressGatewayPolicyParams allows now to use a single policy template across all test scenarios, stop passing the same policy template to all invocations of WithCiliumEgressPolicy() Signed-off-by: Gilberto Bertin <jibi@cilium.io>
and make it available to hooks Signed-off-by: Gilberto Bertin <jibi@cilium.io>
jibi
force-pushed
the
pr/jibi/egressgw-cli-tests-improv
branch
from
3c8b316
to
162da0a
Compare
yeah that's fair 👍 perhaps I can rename it to |
rename the ExcludedCIDRs CiliumEgressGatewayPolicyParams field to ExcludedCIDRsConf to make it more explicit its use case Signed-off-by: Gilberto Bertin <jibi@cilium.io>
brlbil
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see individual commits