Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectivity: don't use an ephemeral port for the echo server #2073

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

jibi
Copy link
Member

@jibi jibi commented Nov 1, 2023

as otherwise replies to traffic SNATed with that same source port will get rejected by the HostPort service

as otherwise replies to traffic SNATed with that same source port will
get rejected by the HostPort service

Signed-off-by: Gilberto Bertin <jibi@cilium.io>
@jibi jibi added the area/CI Continuous Integration testing issue or flake label Nov 1, 2023
@jibi jibi requested a review from brb November 1, 2023 08:46
@jibi jibi requested a review from a team as a code owner November 1, 2023 08:46
@jibi jibi requested a review from tklauser November 1, 2023 08:46
@jibi jibi temporarily deployed to ci November 1, 2023 08:47 — with GitHub Actions Inactive
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As a follow-up, we could add a sanity check.

@tklauser
Copy link
Member

tklauser commented Nov 1, 2023

External workloads workflow is failing due to #2070. All other workflows passed, merging.

@tklauser tklauser merged commit 82e564a into main Nov 1, 2023
17 of 19 checks passed
@tklauser tklauser deleted the pr/jibi/fix-echo-server-host-port branch November 1, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants