Enable running connectivity tests requiring a node without Cilium in combination with clustermesh #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
force-pushed
the
pr/giorio94/more-tests-compatible-with-clustermesh
branch
from
8761380
to
d1534e6
Compare
giorio94
force-pushed
the
pr/giorio94/more-tests-compatible-with-clustermesh
branch
from
d1534e6
to
f482c1f
Compare
giorio94
force-pushed
the
pr/giorio94/more-tests-compatible-with-clustermesh
branch
from
f482c1f
to
709898d
Compare
giorio94
force-pushed
the
pr/giorio94/more-tests-compatible-with-clustermesh
branch
from
709898d
to
70fe178
Compare
christarazi
approved these changes
Dec 18, 2023
nbusseneau
approved these changes
Dec 19, 2023
Yes, they are part of cilium/cilium#29926. |
squeed
approved these changes
Jan 8, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
@giorio94 looks like this picked up a merge conflict. Could you please rebase and resolve? |
tklauser
added
the
needs-rebase
Currently, the deployment originating the pod scheduled on a node without Cilium is added to the incorrect wait list. While this does not create issues in single cluster environments (given that they are merged anyhow as there's a single client), it does not work with clustermesh, as we would use the incorrect client to wait until it becomes ready. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
The detected PodCIDRs are later used to configure the routes required by "from-outside" tests. Let's make sure that we retrieve them for both local and remote nodes when clustermesh is enabled, so that we can run these tests also in that case. From outside tests work under the assumption that the nodes (of both clusters) are on the same LAN, and therefore we can configure a direct route targeting them. This holds for CI workflows using Kind. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
756b7a2 ("connectivity: skip nodeport tests with clustermesh if KPR is disabled") skipped the execution of NodePort tests in the aforementioned scenario, as iptables/ipvs don't know about remote endpoints. Let's add the same requisite also to the other N/S loadbalancing tests, to ensure they are compatible with clustermesh. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
The echo-other-node deployment is hosted on the remote cluster in case of clustermesh, which allows to additionally test that ingress and multi cluster services play well together. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Extend the tests generating traffic from nodes external to the cluster (i.e., without Cilium) to the echo pods to cover both address families, when enabled. To this end, let's additionally configure routes towards the IPv6 PodCIDR. We explicitly skip the configuration for the CIDRs of the nodes where Cilium is not installed, as the insertion of an IPv6 route with next hop a local address appears to fail with: ip: RTNETLINK answers: Invalid argument Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Make sure that the host-netns daemonsets leveraged by the connectivity tests are ready before proceeding with the subsequent checks, to prevent possible flakiness caused by some pods not being yet completely running. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
They will never, because no CNI is present at that point. Hence, let's just avoid wasting one minute waiting for the timeout to expire. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
The v1beta2 API is no longer recognized by newer versions of kubeadm. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Let's make sure that we don't introduce regressions in the tests requiring an external node that doesn't run cilium when enabled in combination with clustermesh. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
pr/giorio94/more-tests-compatible-with-clustermesh
branch
from
70fe178
to
e6ddd1c
Compare
giorio94
removed
needs-rebase
Thanks for the heads up! Rebased. |
maintainer-s-little-helper
bot
added
the
ready-to-merge
tklauser
deleted the
pr/giorio94/more-tests-compatible-with-clustermesh
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review commit by commit, and refer to the individual messages for additional details.