Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make connectivity test pods terminate quickly #2195

Merged

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Dec 19, 2023

Let's use the proper pause entrypoint, instead of sleep, so that the container reacts to signals and terminates immediately when the pod is deleted, instead of waiting for the expiration of the grace period.

Related: cilium/alpine-curl#97

Let's use the proper pause entrypoint, instead of sleep, so that the
container reacts to signals and terminates immediately when the pod
is deleted, instead of waiting for the expiration of the grace period.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 force-pushed the mio/quick-connectivity-test-pods-termination branch from 219dc39 to f1a5b45 Compare January 9, 2024 14:19
@giorio94 giorio94 marked this pull request as ready for review January 9, 2024 16:40
@giorio94 giorio94 requested a review from a team as a code owner January 9, 2024 16:40
@giorio94 giorio94 requested a review from tklauser January 9, 2024 16:40
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 10, 2024
@tklauser tklauser merged commit 46b4188 into cilium:main Jan 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants