Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: export json/yaml utils #2198

Merged
merged 2 commits into from
Dec 20, 2023
Merged

internal: export json/yaml utils #2198

merged 2 commits into from
Dec 20, 2023

Conversation

jibi
Copy link
Member

@jibi jibi commented Dec 19, 2023

No description provided.

@jibi
internal: export EscapeJSONPatchString method
433c682 
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
@jibi jibi added the area/CI Continuous Integration testing issue or flake label Dec 19, 2023
@jibi jibi requested review from a team as code owners December 19, 2023 13:57
chancez
chancez reviewed Dec 19, 2023
View reviewed changes
utils/yaml/yaml.go Outdated Show resolved Hide resolved
chancez
chancez approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@chancez chancez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than minor spelling issue

tommyp1ckles
tommyp1ckles approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@tommyp1ckles tommyp1ckles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Just curious, whats the context?

@jibi
internal: export MustUnmarshalYAML/MustUnmarshalYAMLMulti methods
1d5279e 
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
@jibi jibi force-pushed the pr/jibi/export-json-yaml-utils branch from cf93fc5 to 1d5279e Compare December 20, 2023 09:15
@jibi jibi merged commit b9d06a6 into main Dec 20, 2023
13 checks passed
@jibi jibi deleted the pr/jibi/export-json-yaml-utils branch December 20, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chancez chancez chancez approved these changes

@asauber asauber asauber approved these changes

@christarazi christarazi christarazi approved these changes

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

@squeed squeed Awaiting requested review from squeed squeed is a code owner automatically assigned from cilium/helm

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jibi @chancez @asauber @christarazi @tommyp1ckles