Make cilium clustemesh status compatible with external kvstore #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's return the last retrieved status also when the --wait timeout expires, so that users can know which nodes are not connected. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
c4e47b4 ("clustermesh status: validate expected number of clusters") extended the clustermesh status command to retrieve the list of expected clusters to connect to from the clustermesh secret, to prevent flakiness caused by a change not having yet been observed by the agents. Yet, a possible entry concerning the local cluster is not ignored (as instead agents do), causing the check to always fail in that case. Let's fix it. Fixes: c4e47b4 ("clustermesh status: validate expected number of clusters") Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
The clustermesh-apiserver cannot be used in combination with Cilium running in kvstore mode when the identity allocation mode is kvstore. In this case, remote clusters shall be configured to directly connect to the local etcd cluster. Let's extend the `clustermesh status` command to additionally cover this setup, ignoring the validation of clustermesh-apiserver specific resources. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
mio/clustermesh-external-kvstore
branch
from
493dfe8
to
990912f
Compare
marseel
approved these changes
Jan 4, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clustermesh-apiserver cannot be used in combination with Cilium running in kvstore mode when the identity allocation mode is kvstore. In this case, remote clusters shall be configured to directly connect to the local etcd cluster. Let's extend the
clustermesh statuscommand to additionally cover this setup, ignoring the validation of clustermesh-apiserver specific resources.Additionally, let's improve the reporting in case
cilium clustermesh status --waittimes out, and fix an issue causing it to always report an error if the clustermesh secret also includes the configuration for the local cluster.