-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgp: Add command for retrieving bgp routes #2201
Conversation
02cf06f
to
81a8842
Compare
81a8842
to
fa3be49
Compare
fa3be49
to
f34bffa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, LGTM.
f34bffa
to
83a39c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rastislavs Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rastislavs Thank you for the updates!
This change introduces a new BGP status command: `cilium bgp routes`. BGP routes can be retrieved from all or a specific node in json or summary formats. Vendor update as part of the change is due to the necessary BGP packet types from GoBGP. Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
The change adds an alias for the existing `cilium bgp peers` command (`cilium bgp neighbors`) to align with `cilium-dbg`. Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
f7287af
to
59d79a8
Compare
@sayboras could you please take a look at this PR? It is now missing only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✔️
This change introduces a new BGP status command:
cilium bgp routes
. BGP routes can be retrieved from either all or a specific node; in json or summary formats.The implementation follows the existing patterns of the
cilium bgp peers
command and mirrors thecilium-dbg bgp routes
CLI added in cilium/cilium#27182 .The change also adds an alias for the existing
cilium bgp peers
command (cilium bgp neighbors
) to align withcilium-dbg
.Vendor updates as part of the change is mostly due to the necessary BGP packet types from GoBGP.
Examples:
Help:
Simplest use:
Advertised routes to a specific peer of a specific node:
The same as json: