Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update quay.io/cilium/json-mock docker tag to v1.3.8 #2214

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 9, 2024

Mend Renovate

This PR contains the following updates:

Package Update Change
quay.io/cilium/json-mock patch v1.3.6 -> v1.3.8

Configuration

πŸ“… Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Never, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner January 9, 2024 10:39
@renovate renovate bot added kind/enhancement This would improve or streamline existing functionality. priority/release-blocker This issue will prevent the release of the next version of Cilium. renovate/stop-updating Tell Renovate to stop updating PR labels Jan 9, 2024
@renovate renovate bot requested a review from tklauser January 9, 2024 10:39
@tklauser
Copy link
Member

tklauser commented Jan 9, 2024

In all failing workflows the echo-same-node pods using the new json-mock image are failing to become ready. I assume this is due to the changes in the new version, namely cilium/json-mock#144? cc @giorio94

@giorio94
Copy link
Member

giorio94 commented Jan 9, 2024

In all failing workflows the echo-same-node pods using the new json-mock image are failing to become ready. I assume this is due to the changes in the new version, namely cilium/json-mock#144? cc @giorio94

Yes, although I haven't yet figured out the reason. The image built from my PR works correctly, while the one from the release doesn't (there are no additional commits there). I assume that some underlying component must have changed in the meanwhile.

$ docker run -e PORT=8080 quay.io/cilium/json-mock-ci:5d5776ab3730393c0fc7a3f884452f18bfcac616 # works as expected
$ docker run -e PORT=8080 quay.io/cilium/json-mock-ci:93b660294967f9fc1df1e41ea2a31ce50578b489 # fails

@giorio94
Copy link
Member

giorio94 commented Jan 9, 2024

The difference is the json-server version which is installed:

# Working:
npm list -g
/usr/local/lib
+-- corepack@0.23.0
+-- json-server@0.17.4
`-- npm@10.2.4

# Not working:
npm list -g
/usr/local/lib
+-- corepack@0.23.0
+-- json-server@1.0.0-alpha.14
`-- npm@10.2.4

@giorio94
Copy link
Member

giorio94 commented Jan 9, 2024

I've opened cilium/json-mock#146 to fix it.

Signed-off-by: renovate[bot] <bot@renovateapp.com>
@renovate renovate bot changed the title chore(deps): update quay.io/cilium/json-mock docker tag to v1.3.7 chore(deps): update quay.io/cilium/json-mock docker tag to v1.3.8 Jan 9, 2024
@renovate renovate bot force-pushed the renovate/quay.io-cilium-json-mock-1.3.x branch from 95b5f3f to b7cee7e Compare January 9, 2024 13:46
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 10, 2024
@tklauser tklauser merged commit 1f276cd into main Jan 10, 2024
13 checks passed
@tklauser tklauser deleted the renovate/quay.io-cilium-json-mock-1.3.x branch January 10, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement This would improve or streamline existing functionality. priority/release-blocker This issue will prevent the release of the next version of Cilium. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. renovate/stop-updating Tell Renovate to stop updating PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants