connectivity: only wait for daemonsets if needed #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The host-netns-non-cilium and host-netns daemonsets leveraged by the connectivity tests are only deployed in specific situations. Do not wait for them in other cases, as it blocks the tests. Signed-off-by: Angelos Kolaitis <neoaggelos@gmail.com>
neoaggelos
force-pushed
the
fix/test-wait-daemonsets
branch
from
8be984f
to
71f6235
Compare
|
Hi @tklauser tried to amend to kick the tires of CI, but I still seem to be getting some failures there, not sure if they are flaky or related with the changes of this PR. |
The failed test looks like a timeout unrelated to this PR. I've re-triggered the respective workflow. I'll take a look at the change later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2236
Description
The host-netns-non-cilium and host-netns daemonsets leveraged by the connectivity tests are only deployed in specific situations. Do not wait for them in other cases, as it blocks the tests.
Notes
Only tested on my environment, not sure if maintainers would prefer a different fix. Happy to update the PR as needed, thanks!
An alternative approach would be for
WaitDaemonSetto not retry anynot founderrors, but that might have more unintended consequences, hence I decided not to do it like this.