connectivity: add unknown ICMPv4 code as expected drop reason #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ICMP destination unreachable packets are dropped with "Unknown ICMPv4
code" reason when Cilium is configured with both KPR and BPF masquerade
enabled, except that in the fragmentation needed case. Hence, let's add them
to the default list of expected drop reasons, as they can be legitimately
generated for instance when connecting to a NodePort if the corresponding
backend is not yet ready, as in the clustermesh case:
172.18.0.7:35748 (ID:9) <> kube-system/clustermesh-apiserver:32379 (host) from-network FORWARDED (TCP Flags: SYN)
172.18.0.2 (host) <> 172.18.0.7 (ID:9) Unknown ICMPv4 code DROPPED (ICMPv4 DestinationUnreachable(Port))
Otherwise the no-unexpected-packet-drops test fails with:
馃煡 Found unexpected packet drops:
{
"labels": {
"direction": "EGRESS",
"reason": "Unknown ICMPv4 code"
},
"name": "cilium_drop_count_total",
"value": 10
}
Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
|
@giorio94 In your example, why is the direction egress? |
asauber
approved these changes
Jan 23, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
AFAIU, egress refers to the direction of the ICMP DestinationUnreachable packet which fails to be masqueraded when trying to egress the node that originated it. |
michi-covalent
removed this pull request from the merge queue due to the queue being cleared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICMP destination unreachable packets are dropped with "Unknown ICMPv4 code" reason when Cilium is configured with both KPR and BPF masquerade enabled, except that in the fragmentation needed case. Hence, let's add them to the default list of expected drop reasons, as they can be legitimately generated for instance when connecting to a NodePort if the corresponding backend is not yet ready, as in the clustermesh case:
Otherwise the
no-unexpected-packet-dropstest fails with:馃煡 Found unexpected packet drops: