Minor improvements concerning the tunnel feature determination for connectivity tests #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that it is easier to reuse the same logic from external hooks. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Let's improve the consistency in the determination of the tunnel feature, and ensure that also in case of native routing mode we retrieve the correct tunnel protocol. Indeed, certain features (e.g., egress gateway) still rely on the configured tunnel protocol even if the main routing mode is native. While being there, let's also increase the test coverage of this logic. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
|
Kind / Kind Installation and Connectivity Test failed due to #2204 |
asauber
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
These changes look good.
That being said, why is this not using the more global Feature Set parser? https://github.com/cilium/cilium-cli/blob/main/utils/features/features.go#L219
Nevermind, I see that there's a separate codepath based on Cilium version.
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the individual commit messages for additional details.