Retrieve CiliumNodes in connectivity tests context, and use them to determine PodCIDRs #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CiliumNodes to the list of resources which are retrieved during connectivity tests initialization, and stored for later access from individual tests. Indeed, CiliumNodes contain additional information compared to plain Kubernetes Node objects, especially around IPAM. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
|
Converting back to draft as one of the CI failures seems legitimate. |
Leverage the CiliumNode resources instead of plain K8s Node ones to determine the PodCIDRs used for certain (unsafe) tests, so that we retrieve the correct CIDR both in case of kubernetes and cluster-pool IPAM modes, whereas now it only works in the first case. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
mio/retrieve-cilium-node
branch
from
46d19c7
to
9c16fa4
Compare
|
CI is green. Marking ready for review again. |
tklauser
approved these changes
Jan 24, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CiliumNodes to the list of resources which are retrieved during connectivity tests initialization, and stored for later access from individual tests. Indeed, CiliumNodes contain additional information compared to plain Kubernetes Node objects, especially around IPAM. Additionally, leverage them to determine the PodCIDRs used for certain (unsafe) tests, so that we retrieve the correct CIDR both in case of kubernetes and cluster-pool IPAM modes, whereas now it only works in the first case.