bgp: routes CLI - update min. cilium version, use cilium binary
#2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the necessary cilium-dbg functionality for retrieving BGP routes was backported to cilium v1.14.6 (cilium/cilium#30205), we have to use `cilium` binary instead of `cilium-dbg` to fetch routes from cilium pods, as the rename from `cilium` to `cilium-dbg` happened in 1.15. This also updates the minimal cilium version for this command. Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
harsimran-pabla
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Thanks, we should think about detecting cilium version and use corresponding cilium binary name. That's bit complicated and should probably be generalized across cli. When cilium alias to cilium-dbg gets deprecated from newer releases - we will have to figure this out. For now, this lgtm - thanks :)
rastislavs
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the necessary cilium-dbg functionality for retrieving BGP routes was backported to cilium v1.14.6 (cilium/cilium#30205), we have to use the
ciliumbinary instead ofcilium-dbgto fetch routes from cilium pods, as the rename fromciliumtocilium-dbghappened in 1.15.This also updates the minimal cilium version for this command in the command description.