Unbreak the EKS (tunnel) CI workflow reverting a no-longer necessary workaround #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
…low" This reverts commit bbebbfa. Let's revert the flush stale AWS-CNI iptables rules workaround, as this operation is now automatically handled by Cilium [1,2]. Since bumping the Cilium version used in the EKS workflows to one which includes all fixes (v1.14.6), this workaround has also started failing, as the stale rules attempted to be removed are no longer present. [1]: cilium/cilium#28697 [2]: cilium/cilium#29448 Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
pr/giorio94/gha-eks-tunnel
branch
from
f4ad24c
to
dc01eb0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
giorio94
force-pushed
the
pr/giorio94/gha-eks-tunnel
branch
from
8db3056
to
f3614ad
Compare
|
The EKS (tunnel) workflow completed successfully: https://github.com/cilium/cilium-cli/actions/runs/7708356182/job/21007428796?pr=2273. Dropping the temporary commit and marking ready for review. |
giorio94
force-pushed
the
pr/giorio94/gha-eks-tunnel
branch
from
f3614ad
to
dc01eb0
Compare
|
I've removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "gha: cleanup stale AWS-CNI iptables rules in EKS tunnel workflow"
This reverts commit bbebbfa.
Let's revert the flush stale AWS-CNI iptables rules workaround, as this operation is now automatically handled by Cilium [1,2]. Since bumping the Cilium version used in the EKS workflows to one which includes all fixes (v1.14.6), this workaround has also started failing, as the stale rules attempted to be removed are no longer present.
[1]: cilium/cilium#28697
[2]: cilium/cilium#29448