Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: Upgrade API version #2285

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Feb 5, 2024

This is to avoid the below warning

W0205 12:29:06.703289  146168 warnings.go:70] The v1alpha2 version of ReferenceGrant has been deprecated and will be removed in a future release of the API. Please upgrade to v1beta1.

This is to avoid the below warning

```
W0205 12:29:06.703289  146168 warnings.go:70] The v1alpha2 version of ReferenceGrant has been deprecated and will be removed in a future release of the API. Please upgrade to v1beta1.
```

Signed-off-by: Tam Mach <tam.mach@cilium.io>
Copy link
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIU this will break backward compatibility support for clusters with Cilium v1.13 installed. This version still installs Gateway API in version 0.5.1 that doesn't contain the new api versions.

Is this ok?

@sayboras
Copy link
Member Author

sayboras commented Feb 5, 2024

AFAIU this will break backward compatibility support for clusters with Cilium v1.13 installed. This version still installs Gateway API in version 0.5.1 that doesn't contain the new api versions.

Is this ok?

I think it should be alright as long as we have another entry for 1.15+ in https://github.com/cilium/cilium-cli?tab=readme-ov-file#releases

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 6, 2024
@sayboras sayboras merged commit a960878 into cilium:main Feb 6, 2024
13 checks passed
@sayboras sayboras deleted the tam/upgrade-gateway branch February 6, 2024 08:20
sayboras added a commit to sayboras/cilium-cli that referenced this pull request Feb 27, 2024
This is to address the below comment.

cilium#2285 (comment)
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to sayboras/cilium-cli that referenced this pull request Feb 28, 2024
This is to address the below comment.

cilium#2285 (comment)
Signed-off-by: Tam Mach <tam.mach@cilium.io>
michi-covalent pushed a commit that referenced this pull request Feb 28, 2024
This is to address the below comment.

#2285 (comment)
Signed-off-by: Tam Mach <tam.mach@cilium.io>
aanm pushed a commit to aanm/cilium that referenced this pull request Mar 7, 2024
GitHub Pull Request: #623

chore(deps): update dependency cilium/cilium-cli to v0.15.23 (v1.15)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [cilium/cilium-cli](https://togithub.com/cilium/cilium-cli) |  | patch | `v0.15.22` -> `v0.15.23` |
| [cilium/cilium-cli](https://togithub.com/cilium/cilium-cli) | action | patch | `v0.15.22` -> `v0.15.23` |

---

### Release Notes

<details>
<summary>cilium/cilium-cli (cilium/cilium-cli)</summary>

### [`v0.15.23`](https://togithub.com/cilium/cilium-cli/releases/tag/v0.15.23)

[Compare Source](https://togithub.com/cilium/cilium-cli/compare/v0.15.22...v0.15.23)

#### What's Changed

-   gateway: Upgrade API version by [@&cilium#8203;sayboras](https://togithub.com/sayboras) in [cilium/cilium-cli#2285
-   chore(deps): update dependency kubernetes-sigs/kind to v0.21.0 by [@&cilium#8203;renovate](https://togithub.com/renovate) in [cilium/cilium-cli#2284
-   IPsec key rotation command. by [@&cilium#8203;viktor-kurchenko](https://togithub.com/viktor-kurchenko) in [cilium/cilium-cli#2266
-   IPsec key status command implementation. by [@&cilium#8203;viktor-kurchenko](https://togithub.com/viktor-kurchenko) in [cilium/cilium-cli#2287
-   AWS OIDC instead of access key. by [@&cilium#8203;viktor-kurchenko](https://togithub.com/viktor-kurchenko) in [cilium/cilium-cli#2297
-   Remove no longer necessary step from the external workloads installation script generation process by [@&cilium#8203;giorio94](https://togithub.com/giorio94) in [cilium/cilium-cli#2275
-   Enable no-errors-in-logs check by default, and extend it to all Cilium components by [@&cilium#8203;giorio94](https://togithub.com/giorio94) in [cilium/cilium-cli#2184
-   chore(deps): update golangci/golangci-lint-action action to v4 by [@&cilium#8203;renovate](https://togithub.com/renovate) in [cilium/cilium-cli#2295
-   chore(deps): update helm/kind-action action to v1.9.0 by [@&cilium#8203;renovate](https://togithub.com/renovate) in [cilium/cilium-cli#2296
-   chore(deps): update golang docker tag to v1.22.0 by [@&cilium#8203;renovate](https://togithub.com/renovate) in [cilium/cilium-cli#2289
-   fix(deps): update module golang.org/x/mod to v0.15.0 by [@&cilium#8203;renovate](https://togithub.com/renovate) in [cilium/cilium-cli#2294
-   chore(deps): update go to v1.22.0 (minor) by [@&cilium#8203;renovate](https://togithub.com/renovate) in [cilium/cilium-cli#2293
-   chore(deps): update all github action dependencies (patch) by [@&cilium#8203;renovate](https://togithub.com/renovate) in [cilium/cilium-cli#2286
-   chore(deps): update golangci/golangci-lint docker tag to v1.56.1 by [@&cilium#8203;renovate](https://togithub.com/renovate) in [cilium/cilium-cli#2290
-   IPsec key rotation with algorithm change support. by [@&cilium#8203;viktor-kurchenko](https://togithub.com/viktor-kurchenko) in [cilium/cilium-cli#2291
-   chore: Amend connectivity tests for OpenShift by [@&cilium#8203;fgiloux](https://togithub.com/fgiloux) in [cilium/cilium-cli#2303
-   Increase timeouts in AKS and GKE GHA workflows by [@&cilium#8203;giorio94](https://togithub.com/giorio94) in [cilium/cilium-cli#2307
-   gha: increase GKE disk size in external workloads workflow to 15GB by [@&cilium#8203;giorio94](https://togithub.com/giorio94) in [cilium/cilium-cli#2301
-   Prepare for v0.15.23 release by [@&cilium#8203;michi-covalent](https://togithub.com/michi-covalent) in [cilium/cilium-cli#2302

#### New Contributors

-   [@&cilium#8203;fgiloux](https://togithub.com/fgiloux) made their first contribution in [cilium/cilium-cli#2303

**Full Changelog**: cilium/cilium-cli@v0.15.22...v0.15.23

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on monday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/aanm/cilium).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoidjEuMTUifQ==-->


Patch-set: 1
Change-id: I515325620aa4905df61d31323487f6936237e3a5
Subject: chore(deps): update dependency cilium/cilium-cli to v0.15.23
Branch: refs/heads/v1.15
Status: new
Topic: 
Commit: 7c37f7d
Tag: autogenerated:gerrit:newPatchSet
Groups: 7c37f7d
Private: false
Work-in-progress: false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants