connectivity: improve reporting for no-unexpected-packet-drops check #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's leverage the GenericAction construct to provide better progress and error reporting for the given test, displaying the node associated with any issue and ensuring that we continue checking for problems also after that a first one has been found. Let's also configure it to still capture a single sysdump regardless of the number of failures. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
mio/no-packets-drop-check-improve-reporting
branch
from
734ce38
to
28ad6c4
Compare
gentoo-root
approved these changes
Feb 19, 2024
|
@danehans Gentle ping 🙏 |
tklauser
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's leverage the GenericAction construct to provide better progress and error reporting for the given test, displaying the node associated with any issue and ensuring that we continue checking for problems also after that a first one has been found. Let's also configure it to still capture a single sysdump regardless of the number of failures.