Delete classic mode install/uninstall/upgrade commands #2328

michi-covalent · 2024-02-25T07:57:20Z

gandro

Overall this looks good to me, modulo some doc changes.

Would it help to do a cilium/cilium CI run with a version of cilium-cli with this patch applied? Or are we certain that the classic mode is not used anywhere?

internal/cli/cmd/cmd.go

Ref: #2327 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent · 2024-02-26T15:49:09Z

running the CI here => cilium/cilium#30978

edit: it's all green ✅

michi-covalent temporarily deployed to ci February 25, 2024 07:57 — with GitHub Actions Inactive

michi-covalent force-pushed the pr/michi/install-cleanup branch from 7b68be3 to 86df758 Compare February 25, 2024 08:02

michi-covalent temporarily deployed to ci February 25, 2024 08:02 — with GitHub Actions Inactive

michi-covalent force-pushed the pr/michi/install-cleanup branch from 86df758 to 13e489f Compare February 25, 2024 08:12

michi-covalent temporarily deployed to ci February 25, 2024 08:12 — with GitHub Actions Inactive

michi-covalent force-pushed the pr/michi/install-cleanup branch from 13e489f to 8de02a6 Compare February 25, 2024 08:19

michi-covalent had a problem deploying to ci February 25, 2024 08:19 — with GitHub Actions Error

michi-covalent force-pushed the pr/michi/install-cleanup branch from 8de02a6 to 3464902 Compare February 25, 2024 08:20

michi-covalent temporarily deployed to ci February 25, 2024 08:20 — with GitHub Actions Inactive

michi-covalent force-pushed the pr/michi/install-cleanup branch from 3464902 to 9355255 Compare February 25, 2024 19:27

michi-covalent temporarily deployed to ci February 25, 2024 19:27 — with GitHub Actions Inactive

michi-covalent changed the title ~~delete~~ Delete classic mode install/uninstall/upgrade commands Feb 25, 2024

michi-covalent requested a review from tklauser February 26, 2024 00:34

michi-covalent marked this pull request as ready for review February 26, 2024 00:34

michi-covalent requested review from a team as code owners February 26, 2024 00:34

michi-covalent requested review from tommyp1ckles and gandro February 26, 2024 00:34

gandro requested changes Feb 26, 2024

View reviewed changes

internal/cli/cmd/cmd.go Show resolved Hide resolved

Delete classic mode install/uninstall/upgrade commands

93125c3

Ref: #2327 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent force-pushed the pr/michi/install-cleanup branch from 9355255 to 93125c3 Compare February 26, 2024 15:45

michi-covalent temporarily deployed to ci February 26, 2024 15:45 — with GitHub Actions Inactive

michi-covalent added a commit to cilium/cilium that referenced this pull request Feb 26, 2024

DO NOT MERGE Testing cilium/cilium-cli#2328

8a0689e

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent requested a review from gandro February 26, 2024 15:49

gandro approved these changes Feb 26, 2024

View reviewed changes

michi-covalent merged commit e435b47 into main Feb 27, 2024
13 checks passed

michi-covalent deleted the pr/michi/install-cleanup branch February 27, 2024 03:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete classic mode install/uninstall/upgrade commands #2328

Delete classic mode install/uninstall/upgrade commands #2328

michi-covalent commented Feb 25, 2024 •

edited

gandro left a comment

michi-covalent commented Feb 26, 2024 •

edited

Delete classic mode install/uninstall/upgrade commands #2328

Delete classic mode install/uninstall/upgrade commands #2328

Conversation

michi-covalent commented Feb 25, 2024 • edited

gandro left a comment

Choose a reason for hiding this comment

michi-covalent commented Feb 26, 2024 • edited

michi-covalent commented Feb 25, 2024 •

edited

michi-covalent commented Feb 26, 2024 •

edited