connectivity: fix encryption validation with wireguard encap + host fw #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Cilium v1.15 and later (as well as v1.14 if the --wireguard-encapsulate flag is set), when both tunnel encapsulation and WireGuard encryption are enabled, packets are first encapsulated and then encrypted. Let's fix the connectivity check inter-node interface determination when host firewall is additionally enabled, as currently always defaulting to the tunnel interface, which is incorrect (we would flag the packets as unencrypted, even though the encapsulated packets are encrypted afterwards). Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Cilium v1.15 and later (as well as v1.14 if the --wireguard-encapsulate flag is set), when both tunnel encapsulation and WireGuard encryption are enabled, packets are first encapsulated and then encrypted. Let's fix the connectivity check inter-node interface determination when host firewall is additionally enabled, as currently always defaulting to the tunnel interface, which is incorrect (we would flag the packets as unencrypted, even though the encapsulated packets are encrypted afterwards).