connectivity: Remove --delete-cilium-pod-on-nodes flag #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
force-pushed
the
pr/michi/delete-cilium-pod-on-nodes
branch
from
ded62d7
to
ae936a6
Compare
michi-covalent
force-pushed
the
pr/michi/delete-cilium-pod-on-nodes
branch
from
ae936a6
to
595e019
Compare
The flag was added in #1131 but it looks like we ended up not using it. I grepped for 'delete-cilium-pod-on-nodes' in both cilium and cilium-cli repositories but there was no match. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/delete-cilium-pod-on-nodes
branch
from
595e019
to
7197404
Compare
asauber
approved these changes
Feb 27, 2024
christarazi
approved these changes
Feb 28, 2024
|
alright i'm going in. cc @tklauser just a heads up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag was added in #1131 but it looks like we ended up not using it. I grepped for 'delete-cilium-pod-on-nodes' in both cilium and cilium-cli repositories but there was no match.