sniffer: always dump captured packets in assert mode #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we dump unexpected captured packets only when debug mode is enabled. However, this makes troubleshooting possible CI flakes (e.g., caused by too open tcpdump filters) difficult, due to the lack of information about the exact captured packets. Hence, let's just always output them, regardless of the verbosity mode. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
nathanjsweet
approved these changes
Mar 4, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we dump unexpected captured packets only when debug mode is enabled. However, this makes troubleshooting possible CI flakes (e.g., caused by too open tcpdump filters) difficult, due to the lack of information about the exact captured packets. Hence, let's just always output them, regardless of the verbosity mode.