tests: Add exceptions for error logs check #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "Failed to update lock:" and "Failed to release lock:" to log level error excpetions, as these errors originate from vendored code and we can not silence them otherwise. This prevents CI flake like this: ❌ Found 1 logs in kind-kind/kube-system/cilium-operator-799cff46cd-n2lfz (cilium-operator) matching list of errors that must be investigated: level=error msg="Failed to update lock: Operation cannot be fulfilled on leases.coordination.k8s.io \"cilium-operator-resource-lock\": the object has been modified; please apply your changes to the latest version and try again" subsys=klog (1 occurrences) Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
added
area/CI
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "Failed to update lock:" and "Failed to release lock:" to log level error excpetions, as these errors originate from vendored code and we can not silence them otherwise. This prevents CI flake like this:
❌ Found 1 logs in kind-kind/kube-system/cilium-operator-799cff46cd-n2lfz (cilium-operator) matching list of errors that must be investigated:
level=error msg="Failed to update lock: Operation cannot be fulfilled on leases.coordination.k8s.io "cilium-operator-resource-lock": the object has been modified; please apply your changes to the latest version and try again" subsys=klog (1 occurrences)