errors: add [no-error-logs] exception for issue caused by fqdn bug. #2438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommyp1ckles
force-pushed
the
pr/tp/add-case-for-wg-fqdn-proxy-bug
branch
from
d719da5
to
4d787ce
Compare
tommyp1ckles
force-pushed
the
pr/tp/add-case-for-wg-fqdn-proxy-bug
branch
from
4d787ce
to
034121d
Compare
gentoo-root
approved these changes
Mar 21, 2024
gandro
reviewed
Mar 21, 2024
tommyp1ckles
force-pushed
the
pr/tp/add-case-for-wg-fqdn-proxy-bug
branch
from
034121d
to
93141be
Compare
tommyp1ckles
force-pushed
the
pr/tp/add-case-for-wg-fqdn-proxy-bug
branch
from
93141be
to
36895ff
Compare
tommyp1ckles
force-pushed
the
pr/tp/add-case-for-wg-fqdn-proxy-bug
branch
from
36895ff
to
93141be
Compare
tommyp1ckles
force-pushed
the
pr/tp/add-case-for-wg-fqdn-proxy-bug
branch
from
93141be
to
ee4a2dc
Compare
|
/test |
tommyp1ckles
force-pushed
the
pr/tp/add-case-for-wg-fqdn-proxy-bug
branch
from
ee4a2dc
to
4b17050
Compare
|
/test |
tklauser
approved these changes
Mar 26, 2024
There are cases where we want to ignore a specific error log that any relevant substring of may be too general and exclude logs we want to fail on. This switches the except lists to use a logMatcher interface type that is implemented by both a string and regex matcher for log exclusions. Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
FQDN Proxy together running with Wireguard has a bug where proxied dns requests can cause a port collision. See: cilium/cilium#31535 Despite this, the actual fqdn tests seem to be resilient to this, likely due to retries. While we work on a fix for this issue, let's add a temporary exception here. Addresses: cilium/cilium#30901 Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
tommyp1ckles
force-pushed
the
pr/tp/add-case-for-wg-fqdn-proxy-bug
branch
from
4b17050
to
0d51d47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FQDN Proxy together running with Wireguard has an issue where proxied dns requests can cause a port collision. See: cilium/cilium#31535
Despite this, the actual fqdn tests seem to be resilient to this, likely due to retries.
While we work on a fix for this issue, let's add a temporary exception here.