Skip to content

Commit

Permalink
Fix smoke tests by filtering out go_* metrics from metrics linting
Browse files Browse the repository at this point in the history
Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
  • Loading branch information
chancez authored and aanm committed Apr 11, 2022
1 parent bbe2dc1 commit 9e19fc0
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/tests-smoke.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,9 @@ jobs:
tar xzvf prometheus-${PROM_VERSION}.linux-amd64.tar.gz prometheus-${PROM_VERSION}.linux-amd64/promtool
rm -f prometheus-${PROM_VERSION}.linux-amd64.tar.gz
sudo mv prometheus-${PROM_VERSION}.linux-amd64/promtool /usr/bin
cat metrics.prom | promtool check metrics
# filter go_ metrics which do not conform to the _total convention with gauges
# See https://github.com/prometheus/prometheus/issues/10574
cat metrics.prom | grep -v 'go_' | promtool check metrics
- name: Capture cilium-sysdump
if: ${{ failure() }}
Expand Down

0 comments on commit 9e19fc0

Please sign in to comment.