Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipvlan: Avoid spammy dmesg info messages #17709

Merged
merged 1 commit into from Nov 5, 2021

Conversation

chendotjs
Copy link
Contributor

Avoid spamming the kernel log with below messages when creating ipvlan slave:

[Tue Oct 26 14:20:38 2021] cilium: renamed from tmp_svwpi
[Tue Oct 26 14:20:38 2021] cilium: Caught tx_queue_len zero misconfig
[Tue Oct 26 14:20:46 2021] cilium_host: Caught tx_queue_len zero misconfig
[Tue Oct 26 14:32:11 2021] eth0: renamed from tmp6fed1
[Tue Oct 26 14:32:11 2021] eth0: Caught tx_queue_len zero misconfig

@mukeshkwm reported similar issue on veth datapath, which also applies to ipvlan datapath.

Fixes: #17703
Signed-off-by: Chen Yaqi chendotjs@gmail.com

Avoid spamming the kernel log with below messages when creating ipvlan slave:

[Tue Oct 26 14:20:38 2021] cilium: renamed from tmp_svwpi
[Tue Oct 26 14:20:38 2021] cilium: Caught tx_queue_len zero misconfig
[Tue Oct 26 14:20:46 2021] cilium_host: Caught tx_queue_len zero misconfig
[Tue Oct 26 14:32:11 2021] eth0: renamed from tmp6fed1
[Tue Oct 26 14:32:11 2021] eth0: Caught tx_queue_len zero misconfig

@mukeshkwm reported similar issue on veth datapath, which also applies to ipvlan datapath.

Fixes: cilium#17703
Signed-off-by: Chen Yaqi <chendotjs@gmail.com>
@chendotjs chendotjs requested a review from a team October 26, 2021 13:26
@chendotjs chendotjs requested a review from a team as a code owner October 26, 2021 13:26
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 26, 2021
@chendotjs
Copy link
Contributor Author

Ref: #17705

@pchaigno
Copy link
Member

Closing given #17705 was merged.

@pchaigno pchaigno closed this Oct 26, 2021
@chendotjs
Copy link
Contributor Author

@pchaigno @borkmann 😅 correct me if I am wrong, #17705 is the fix for veth ? while this pr is intended for ipvlan.

@borkmann borkmann reopened this Oct 26, 2021
@pchaigno
Copy link
Member

@pchaigno @borkmann sweat_smile correct me if I am wrong, #17705 is the fix for veth ? while this pr is intended for ipvlan.

Oh, sorry 🤦

@pchaigno pchaigno added release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. labels Oct 26, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 26, 2021
Copy link
Contributor

@joamaki joamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but consider using -1 as the constant instead of 1000 so it'll pick whatever is the kernel default.

@chendotjs
Copy link
Contributor Author

It seems that the Checkpatch error is due to difference between github public email and the one in commit description before. Gently asking will this PR get merged?

@pchaigno
Copy link
Member

pchaigno commented Nov 3, 2021

@chendotjs Yes, we'll just ignore that one.

/test

@pchaigno
Copy link
Member

pchaigno commented Nov 5, 2021

Some connectivity issue to the GKE API:
/test-gke

@pchaigno
Copy link
Member

pchaigno commented Nov 5, 2021

Reviews are in. k8s-1.16-kernel-netnext hit known flake #17661. Marking ready to merge and merging.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 5, 2021
@pchaigno pchaigno merged commit a4b5cfe into cilium:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cilium_host/cilium_net: Caught tx_queue_len zero misconfig
4 participants