Fix cilium metrics list: revert "prometheus/client_golang"

[ti-mo]

This reverts commit d8e3f28.

Extra Go metrics were added to the Prometheus client, some having NaN values, breaking json marshaling on the server side of cilium metrics list:

msg="Cilium API handler panicked" panic_message="json: unsupported value: NaN" url=/v1/metrics/ ...

Fixes: #19425

Revert Prometheus client to fix 'cilium metrics list'

[maintainer-s-little-helper]

Commit 3c6a77c2aca9cc5575f3e89b066e2af383f62b54 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[maintainer-s-little-helper]

Commit 3c6a77c2aca9cc5575f3e89b066e2af383f62b54 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[tklauser]

Probably makes sense to ignore github.com/prometheus/client_golang in the dependabot config until a new version with a fix is released. So the bot won't attempt to update the dependency again.

cilium/.github/dependabot.yml

Lines 9 to 18 in b79ebcf

	ignore:
	# using a cilium-specific fork
	- dependency-name: "github.com/miekg/dns"
	# k8s dependencies will be updated manually along with tests
	- dependency-name: "k8s.io/*"
	- dependency-name: "sigs.k8s.io/*"
	# cloud provider SDKs are updated too frequently, update them manually
	- dependency-name: "github.com/aliyun/alibaba-cloud-sdk-go"
	- dependency-name: "github.com/aws/*"
	- dependency-name: "github.com/Azure/*"

[rolinh]

While we're at it and given that dependabot ignores this dep for now, could we bump from v1.11.0 to v1.11.1 to pull in the security fix?

[ti-mo]

@rolinh Good point, done!

[ti-mo]

/test

Job 'Cilium-PR-K8s-GKE' hit: #17628 (95.15% similarity)

[ti-mo]

/test

Job 'Cilium-PR-K8s-1.23-kernel-net-next' hit: #18895 (93.74% similarity)

[ti-mo]

/test

[ti-mo]

/test

Job 'Cilium-PR-K8s-GKE' failed:

Click to show.

Test Name

K8sHealthTest cilium-health Checks status between nodes

Failure Output

FAIL: Kubernetes DNS did not become ready in time

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-GKE so I can create one.

[joestringer]

This seems like a straightforward revert, approvals are in. The CI runs below are hitting issues, the kafka one looks new to me but I don't understand how the PR could be related:

https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/8303/
https://jenkins.cilium.io/job/Cilium-PR-Runtime-net-next/2030/

Please do consider filing issues or referencing existing issues if these are flakes we are not yet tracking. However, given this is resolving a known issue due to the dependency bump, and reverting back to the previous version should be safe, I think this is good to merge.