build(deps): bump sphinx-tabs from 3.3.1 to 3.4.1 #20948
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
kind/enhancement
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
|
@dependabot rebase |
dependabot
bot
force-pushed
the
dependabot/pip/sphinx-tabs-3.4.1
branch
from
ad1e752
to
7a72bbc
Compare
|
This is blocked by #20950 |
qmonnet
requested changes
Aug 19, 2022
dependabot
bot
force-pushed
the
dependabot/pip/sphinx-tabs-3.4.1
branch
from
7a72bbc
to
328f6b9
Compare
|
Looking further, we can't update to 3.4.1 because it requires docutils 0.18, which is not supported by the theme we use for the docs. However, we can update up to 3.4.0, which works with docutils 0.17. This should also allow us to bump sphinx to v5+. I'll submit a PR separately. |
qmonnet
added a commit
to qmonnet/cilium
that referenced
this pull request
Aug 19, 2022
We cannot bump sphinx-tabs to 3.4.1 as proposed by Dependabot in cilium#20948 because that version requires docutils 0.18, which is not supported yet by our theme (or the upstream version we derived it from). However, we can bump to 3.4.0 which does not have this requirement. This allows us to bump Sphinx to 5.1.1. Minor adjustments are required for the configuration file, to prevent warning when building the doc: We must set a language (I used "en" for English, the default fallback according to the warning), and we must have a single '%s' in the captions for extlinks (or use None for no caption). Signed-off-by: Quentin Monnet <quentin@isovalent.com>
joestringer
pushed a commit
that referenced
this pull request
Aug 19, 2022
We cannot bump sphinx-tabs to 3.4.1 as proposed by Dependabot in #20948 because that version requires docutils 0.18, which is not supported yet by our theme (or the upstream version we derived it from). However, we can bump to 3.4.0 which does not have this requirement. This allows us to bump Sphinx to 5.1.1. Minor adjustments are required for the configuration file, to prevent warning when building the doc: We must set a language (I used "en" for English, the default fallback according to the warning), and we must have a single '%s' in the captions for extlinks (or use None for no caption). Signed-off-by: Quentin Monnet <quentin@isovalent.com>
Bumps [sphinx-tabs](https://github.com/executablebooks/sphinx-tabs) from 3.3.1 to 3.4.1. - [Release notes](https://github.com/executablebooks/sphinx-tabs/releases) - [Changelog](https://github.com/executablebooks/sphinx-tabs/blob/master/CHANGELOG.md) - [Commits](executablebooks/sphinx-tabs@v3.3.1...v3.4.1) --- updated-dependencies: - dependency-name: sphinx-tabs dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/pip/sphinx-tabs-3.4.1
branch
from
328f6b9
to
0bac897
Compare
|
Nice, it updates requirements-min.txt as well! Still blocked because of docutils though. |
|
Closing given #20948 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps sphinx-tabs from 3.3.1 to 3.4.1.
Release notes
Sourced from sphinx-tabs's releases.
Changelog
Sourced from sphinx-tabs's changelog.
Commits
9431223RELEASE v3.4.126bad87Change testing to only cover latest sphinx version (#167)b9fd7d8RELEASE: v3.4.09b061d5🐛 FIX: Fix to stop stripping of first line in MyST content (#165)f2b4714👌 IMPROVE: Add support and testing for sphinx 5 (#164)88a096f📚 DOCS: Fix typos (#157)c024ea8[pre-commit.ci] pre-commit autoupdate (#156)193646fChange git to https in pre-commit-hooks (#158)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)