Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: Clean up un-used scripts #32456

Merged
merged 4 commits into from
May 30, 2024
Merged

contrib: Clean up un-used scripts #32456

merged 4 commits into from
May 30, 2024

Conversation

sayboras
Copy link
Member

No description provided.

This script is no longer used, it's better to remove it and all related
script.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 10, 2024
@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label May 10, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 10, 2024
@sayboras
Copy link
Member Author

/test

@sayboras sayboras marked this pull request as ready for review May 10, 2024 14:31
@sayboras sayboras requested a review from a team as a code owner May 10, 2024 14:31
@sayboras sayboras requested a review from qmonnet May 10, 2024 14:31
@qmonnet qmonnet requested a review from a team May 10, 2024 16:52
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, I'm not aware of any of these scripts being in use today. But I asked for a review from maintainers, in case they'd be aware of remaining use cases.

@qmonnet qmonnet added the kind/cleanup This includes no functional changes. label May 10, 2024
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these look like old relics from earlier bash-based CI or tricks to help deploy software that wasn't widely available years ago.

watchtest / watchdo are still part of my regular rotation, but I've integrated those into my own environment so it doesn't make a difference to me whether we continue to share those scripts via the Cilium repo or not.

contrib/shell/test.sh Show resolved Hide resolved
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels May 10, 2024
@squeed squeed removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 15, 2024
@sayboras sayboras added this pull request to the merge queue May 30, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 30, 2024
Merged via the queue into main with commit a8d83f5 May 30, 2024
265 of 268 checks passed
@sayboras sayboras deleted the pr/tammach/cleanup-script branch May 30, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants