-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpv2: Exporting peer, route and route-policy states of BGPv2 via CLI. #32474
Merged
julianwiedmann
merged 2 commits into
cilium:main
from
harsimran-pabla:hpabla/bgp/v2/state
May 15, 2024
Merged
bgpv2: Exporting peer, route and route-policy states of BGPv2 via CLI. #32474
julianwiedmann
merged 2 commits into
cilium:main
from
harsimran-pabla:hpabla/bgp/v2/state
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsimran-pabla
added
release-note/misc
This PR makes changes that have no direct user impact.
area/bgp
labels
May 10, 2024
harsimran-pabla
force-pushed
the
hpabla/bgp/v2/state
branch
from
May 10, 2024 19:04
2fe6f2e
to
af731bc
Compare
/test |
rastislavs
reviewed
May 13, 2024
harsimran-pabla
force-pushed
the
hpabla/bgp/v2/state
branch
2 times, most recently
from
May 13, 2024 14:59
0a2a56f
to
0d79a4c
Compare
/test |
harsimran-pabla
force-pushed
the
hpabla/bgp/v2/state
branch
from
May 13, 2024 15:52
0d79a4c
to
ebd3d76
Compare
/test |
Moving ConfigMode of bgp controller into its own package. It is done so ConfigMode can be used in various other sub-packages without causing circular dependency. Signed-off-by: harsimran pabla <hpabla@isovalent.com>
Add ConfigMode hook in BGPRouterManager, which can be used when getting various states like peers, routes, or route-policies. Adding toggle layer to fetch state from BGPv1 vs BGPv2 gobgp instances based on config mode. Signed-off-by: harsimran pabla <hpabla@isovalent.com>
harsimran-pabla
force-pushed
the
hpabla/bgp/v2/state
branch
from
May 13, 2024 21:13
ebd3d76
to
69e37aa
Compare
rastislavs
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks!
/test |
ci-e2e : lvh-vm timeout https://github.com/cilium/cilium/actions/runs/9079383440/job/24948480372#step:10:1375 |
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/bgp
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change exposes various BGP states from BGPInstances ( BGPv2 implementation ) into existing CLIs. It adds a thin switch layer in BGP manager to get v1 or v2 states.
There is no change to CLI or http API and how users interact with Cilium to get BGP state.
Please see individual commits for peers, routes and route-policies changes.