Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misinterpretation of dashes used as separators for init arguments #226

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

iwereth
Copy link

@iwereth iwereth commented Oct 19, 2022

I was going through the guides since I am quite a newbie to whole Linux ecosystem (thank you so much!) and I found that there is a misinterpretation of dash separators for kernel boot parameters, which was probably caused by the formatting bug the official kernel documentation had torvalds/linux@62ee81b

I tried to make some fixes to the README.adoc to the main page. Moreover, some of the section of guide may have the content rendered as incorrectly making some conclusion about how parameters are parsed, for example the one where you mention about how a.b was parsed

@cirosantilli
Copy link
Owner

cirosantilli commented Oct 20, 2022

Oh, God, I remember being so confused by this... thanks :-) Unfortunately it will also need a few more fixes in other parts of LKMC as I relied on this buggy behavior in some other places too, I'll try to make a more complete fix later, some points:

  • init arguments section dies, gotta check if other things are affected
  • usages of lkmc_home
  • usages of lkmc_eval
  • usages of kernel_cli_after_dash and things that would go into it

@@ -3435,10 +3435,10 @@ at the very end of the boot logs.

=== Init environment

Documented at https://www.kernel.org/doc/html/v4.14/admin-guide/kernel-parameters.html[]:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, never ever use latest on a link. It WILL break one day. I'll fix this later on with my commit.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh alright! I will keep that in mind

@cirosantilli cirosantilli force-pushed the master branch 6 times, most recently from ca85405 to 9724633 Compare May 9, 2023 06:48
@hitoriCai

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants