Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SNSPublisher dest_name handling #274

Merged

Conversation

ircwaves
Copy link
Member

@ircwaves ircwaves commented May 8, 2024

No description provided.

@ircwaves ircwaves force-pushed the fix-passing-topic-name-in-publisher branch from f662443 to c853ea7 Compare May 8, 2024 19:16
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.94%. Comparing base (8f82df5) to head (c853ea7).

❗ Current head c853ea7 differs from pull request most recent head b693ffc. Consider uploading reports for the commit b693ffc to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           release/v0     #274      +/-   ##
==============================================
- Coverage       82.95%   82.94%   -0.01%     
==============================================
  Files              57       57              
  Lines            3033     3032       -1     
==============================================
- Hits             2516     2515       -1     
  Misses            517      517              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ircwaves
Copy link
Member Author

ircwaves commented May 8, 2024

gotta fix the same bits in SQS, in the same fashion.

@jkeifer jkeifer changed the base branch from main to release/v0 May 8, 2024 21:26
@jkeifer
Copy link
Collaborator

jkeifer commented May 8, 2024

Note that I changed the merge target to the branch release/v0. This is going to create a merge conflict with the v1 work and we are super close to merging that, so now's the time to branch off the v0 stuff.

@ircwaves ircwaves marked this pull request as ready for review May 9, 2024 14:24
@ircwaves ircwaves merged commit f697f09 into cirrus-geo:release/v0 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants