Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update locales-he-IL.xml #190

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Update locales-he-IL.xml #190

wants to merge 1 commit into from

Conversation

rmzelle
Copy link
Member

@rmzelle rmzelle commented Feb 18, 2019

Update Hebrew CSL locale file with changes from #146.

@csl-bot
Copy link
Contributor

csl-bot commented Feb 18, 2019

Awesome! You just created a pull request to the Citation Styles Language locales repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your locale file validates.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your locale file to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@@ -23,29 +23,29 @@
<term name="and">ו</term>
<term name="and others">ואחרים</term>
<term name="anonymous">אלמוני</term>
<term name="anonymous" form="short">anon</term>
<term name="anonymous" form="short"></term>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a translation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have asked a Israeli colleague about abbreviations for bibliographic terms in general ("editor", in specific). The answer was that you normally don't use abbreviations for these terms. Instead, you'd just use the regular term. So here, it would be

<term name="anonymous" form="short">אלמוני</term>

Perhaps we could do that for all Hebrew terms with missing localization. That's already much better than having English terms here, and if there are complaints we can still correct the terms then.

<term name="no date">אין נתונים</term>
<term name="no date" form="short">nd</term>
<term name="no date">לא ידוע</term>
<term name="no date" form="short"></term>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a translation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per above

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the no date is referring specifically to publishing details, then:
חש"ד, which is an acronym for חסר שנת דפוס (lit. missing the year of printing). In Hebrew, however, only the acronym is ever used.

<term name="ordinal-07">7</term>
<term name="ordinal-08">8</term>
<term name="ordinal-09">9</term>
<term name="ordinal-10">10</term>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect use of ordinal terms.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly, the problem here that you don't use suffixes for this in Hebrew, but you'll always have
Also: in Hebrew to ordinal appears after---no before---the word that is counted: mahadurah rishonah => first edition; mahadurah shlishit => third edition

<term name="line" form="short">l.</term>
<term name="note" form="short">n.</term>
<term name="opus" form="short">op</term>
<term name="book" form="short"></term>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a translation.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ס'

@rmzelle
Copy link
Member Author

rmzelle commented Feb 18, 2019

@phillipsyoav, @roypeled1, could either of you review my comments above? I prepared a new pull request from @phillipsyoav submission (#146), but there are a few outstanding issues such as missing translations and incorrect use of the "ordinal" terms (which should define the suffixes for ordinal numbers, e.g. "nd" for "2nd", not the numbers themselves).

Thanks!

@adam3smith
Copy link
Member

@rmzelle if you absolutely can't find someone, I can get one of my Hebrew speaking colleagues to look this over, but would be better if someone with more familiarity with Zotero did, of course.

@phillipsyoav
Copy link

Are these issues still relevent?

@denismaier
Copy link
Member

So, what do you we do about this now?

@roypeled1
Copy link
Contributor

roypeled1 commented Jan 13, 2021 via email

@bwiernik
Copy link
Member

@roypeled1 Basically, if you could look over this file and see if there are any terms that are incorrectly translated or for which translations are missing, that would be awesome!

@roypeled1
Copy link
Contributor

roypeled1 commented Jul 25, 2021 via email

@roypeled1
Copy link
Contributor

roypeled1 commented Jul 25, 2021 via email

@denismaier
Copy link
Member

@roypeled1 Thanks!

Could you also look at my comments on the pull request discussion page.
#190

@@ -23,29 +23,29 @@
<term name="and">ו</term>
<term name="and others">ואחרים</term>
<term name="anonymous">אלמוני</term>
<term name="anonymous" form="short">anon</term>
<term name="anonymous" form="short"></term>
<term name="at">-ב</term>
<term name="available at">זמין ב</term>
<term name="by">על-ידי</term>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually is done as ע"י and is not spelled out in full

<term name="cited">מצוטט ב</term>
<term name="edition">
<single>מהדורה</single>
<multiple>מהדורות</multiple>
</term>
<term name="edition" form="short">ed</term>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some journals, they use מה'

<term name="cited">מצוטט ב</term>
<term name="edition">
<single>מהדורה</single>
<multiple>מהדורות</multiple>
</term>
<term name="edition" form="short">ed</term>
<term name="edition" form="short">מהדורה</term>
<term name="et-al">ואחרים</term>
<term name="forthcoming">צפוי</term>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Hebrew journals, I have not seen a differentiation between "forthcoming" and "in press", both using בדפוס. Those who do differentiate would use בקרוב not צפוי

<term name="in press">בהדפסה</term>
<term name="internet">אינטרנט</term>
<term name="in press">בדפוס</term>
<term name="internet">אתר</term>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is generally used for "website"

@@ -57,28 +57,31 @@
<multiple>refs.</multiple>
</term>
<term name="retrieved">אוחזר</term>
<term name="scale">scale</term>
<term name="scale">קנ"מ</term>
<term name="version">גירסה</term>

<!-- ANNO DOMINI; BEFORE CHRIST -->
<term name="ad">לספירה</term>
<term name="bc">לפני הספירה</term>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally uses the acronym לפנה"ס

@@ -154,24 +157,24 @@
<multiple>sub verbis</multiple>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ערך

<term name="section" form="short">ס'</term>
<term name="paragraph" form="short">פ.</term>
<term name="part" form="short">חלק</term>
<term name="section" form="short">סע'</term>
<term name="sub verbo" form="short">
<single>s.v.</single>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ערך

<term name="section" form="short">ס'</term>
<term name="paragraph" form="short">פ.</term>
<term name="part" form="short">חלק</term>
<term name="section" form="short">סע'</term>
<term name="sub verbo" form="short">
<single>s.v.</single>
<multiple>s.vv.</multiple>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ערכים

</term>

<!-- VERB ROLE FORMS -->
<term name="container-author" form="verb">by</term>
<term name="container-author" form="verb">על ידי</term>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ע"י

@@ -268,15 +271,15 @@
<term name="recipient" form="verb">אל</term>
<term name="reviewed-author" form="verb">ע"י</term>
<term name="translator" form="verb">תורגם ע"י</term>
<term name="editortranslator" form="verb">edited &amp; translated by</term>
<term name="editortranslator" form="verb">תורגם ונכרך על ידי:</term>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

תורגם ונערך ע"י

@guymii
Copy link

guymii commented Oct 6, 2022

@denismaier
Why was this request never approved? Is there anyway to get it approved? Should I just open a new pull request with my changes?

@denismaier
Copy link
Member

Well, this has never been merged as it's still a draft.
I guess it would be easier to just open a new pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants