Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update locales-vi-VN.xml #228

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Cuongti
Copy link

@Cuongti Cuongti commented May 20, 2021

In vietnamese, we can not write "6th edition" or "6th ấn bản' or "6th a.b" but we have to write "Tái bản lần thứ 6". "tái bản lần thứ" means "re-edition" because if it's the first edition, we don't need to specify. I don't know how to change, can you guys do that, please ?

CSL Locales Pull Request Template

You're about to create a pull request to the CSL locales repository.
If you haven't done so already, see http://docs.citationstyles.org/en/stable/translating-locale-files.html for instructions on how to translate CSL locale files, and https://github.com/citation-style-language/styles/blob/master/CONTRIBUTING.md on how to submit your changes.
In addition, please fill out the pull request template below.

Description

Briefly describe the changes you're proposing.

Checklist

  • Check that you're listed as a <translator> in the <info> block at the beginning of the file.

In vietnamese, we can not write "6th edition" or "6th ấn bản' or "6th a.b" but we have to write "Tái bản lần thứ 6". "tái bản lần thứ" means "re-edition" because if it's the first edition, we don't need to specify. I don't know how to change, can you guys do that, please ?
@hieutkt
Copy link

hieutkt commented Jul 15, 2021

Hi @Cuongti.

I might be able to solve your problem here.

I'm a native Vietnamese, and I'm willing to spend some time making a proper translation for this locale. In a few more days, I will make another PR, which will properly conform to the guide of submission. If you permit, I can mention you in the PR and include your name in the list of translators.

Would that be okay?

@Cuongti
Copy link
Author

Cuongti commented Jul 15, 2021 via email

@bwiernik
Copy link
Member

@hieutkt @Cuongti You can add a co-author to the new PR so that both contributors are acknowledged: https://docs.github.com/en/github/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants