Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indicate simulation failure with http status #273

Merged
merged 3 commits into from
May 14, 2024
Merged

indicate simulation failure with http status #273

merged 3 commits into from
May 14, 2024

Conversation

bbortt
Copy link
Collaborator

@bbortt bbortt commented May 12, 2024 •
edited

with this change:

  • failures during scenario execution are being reported with custom HTTP status 555.
    • these scenario executions will be FAILURE
  • expected failures (e.g. using the fail-action) are not being reported.
    • these scenario executions will be FAILURE
  • expected error response codes such as HTTP 500 still work.
    • these scenario executions will be SUCCESS

@bbortt bbortt self-assigned this May 12, 2024
@bbortt bbortt force-pushed the fix/some-bugs branch 7 times, most recently from 4a4ffcd to 9da8dd5 Compare May 13, 2024 19:32
@bbortt
Copy link
Collaborator Author

bbortt commented May 13, 2024

there is currently an incident with github actions ongoing: https://www.githubstatus.com/incidents/f7jl0mdd2jr5.

@bbortt bbortt force-pushed the fix/some-bugs branch 2 times, most recently from 4531526 to 8d13e47 Compare May 14, 2024 05:27
@bbortt bbortt changed the title Draft: indicate simulation failure with http status indicate simulation failure with http status May 14, 2024
@bbortt bbortt added Type: Bug READY Prio: High java Pull requests that update Java code labels May 14, 2024
@bbortt
Copy link
Collaborator Author

bbortt commented May 14, 2024

closes #271.

@bbortt bbortt linked an issue May 14, 2024 that may be closed by this pull request
failing simulations should result in failure response type #271
Closed
@bbortt bbortt merged commit 8a2ebd2 into citrusframework:main May 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bbortt bbortt

Labels
documentation java Pull requests that update Java code Prio: High READY Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failing simulations should result in failure response type
1 participant
@bbortt