fix: parameter list parsing #1131
Conversation
| assertEquals(resolveFunction("citrus:concat('Hello Yes, I like Citrus!', 'Hello Yes,we like Citrus!')", context), "Hello Yes, I like Citrus!Hello Yes,we like Citrus!"); | ||
| assertEquals(resolveFunction("citrus:concat('Hello Yes, I like Citrus, and this is great!', 'Hello Yes,we like Citrus, and this is great!')", context), "Hello Yes, I like Citrus, and this is great!Hello Yes,we like Citrus, and this is great!"); | ||
|
|
||
| // assertEquals(resolveFunction("citrus:upperCase(''Yes, I like Citrus!)", context), "''YES, I LIKE CITRUS!"); |
There was a problem hiding this comment.
I don't really understand those three test - are they really intended like that?
Because compared i.E. to CSV (if I recall correct), if quotes are present in a string, they need to be inside quotes.
There was a problem hiding this comment.
so, apparently unequal amount of quotes were accepted / ignored. and these few tests here do no longer pass, because of the provided fix in the parser. is that what you mean?
| * @param parameterString comma separated parameter string. | ||
| * @return list of parameters. | ||
| */ | ||
| public static List<String> getParameterList(String parameterString) { | ||
| List<String> parameterList = new ArrayList<>(); | ||
| return new ParameterParser(parameterString).parse(); |
There was a problem hiding this comment.
The longer I think about that... wouldn't it be easier to just use a CSV-Parser for that?
There was a problem hiding this comment.
Hey @bbortt
Your thoughts on that?
There was a problem hiding this comment.
hm.. I think CSV uses double quotes for concatenation. that's a bit problematic in the context of Java. other than that, I do too think that it's the same parsing logic.
novarx
force-pushed
the
fix/parameter-list
branch
from
05aeeb0
to
ddeb9a0
Compare
If i.e. following value is passed to
getParameterList:it results in following String:
(see tests for more examples)