-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validate json array order if strict mode #1155
fix: validate json array order if strict mode #1155
Conversation
I think there is the need to configure the json array ordering separately from the |
...-validation-json/src/main/java/org/citrusframework/validation/json/JsonElementValidator.java
Outdated
Show resolved
Hide resolved
...-validation-json/src/main/java/org/citrusframework/validation/json/JsonElementValidator.java
Show resolved
Hide resolved
...idation-json/src/test/java/org/citrusframework/validation/json/JsonElementValidatorTest.java
Show resolved
Hide resolved
...idation-json/src/test/java/org/citrusframework/validation/json/JsonElementValidatorTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
To have this properly documented, I kindly ask to create an issue to document the change, that non strict json validation now allows additional elements at any position in the array, while still enforcing the correct order of the control array elements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with the current solution, knowing that @etieskrill is working on another feature to make this even more customizable.
update documentation
7f68853
to
ada6350
Compare
See #1157
A follow up to #1102
It seems that not validating the order of json arrays if
strict
is not the desired behaviour.see #1102 (comment)