Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#1156): provide test api generator #1160

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tschlat
Copy link
Collaborator

@tschlat tschlat commented May 13, 2024

I have added code for the test API generator plus documentation. The generator has been implemented having XML tests in mind. Therefore, usage within Java DSL is a little cumbersome and needs a rework. We propose to add this change as work in progress. It is quite isolated.

I have added #1161 and #1163 to finish this up.

Copy link
Collaborator

@bbortt bbortt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huge @tschlat! I won't be nitpicking on this 🐤 but left some remarks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file must be included somewhere, right? I would suggest to add it after "5. Running tests in Java".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved it to connector-openapi.adoc and embdedded it into that context.

= Test API Generation

== OpenAPI: A Standard for API Description
OpenAPI, formerly known as Swagger, is a widely adopted standard for describing RESTful APIs. It provides a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually do one sentence per line in *.adoc. that makes it much more comparable in later pull-requests. would you mind giving it a refactoring? 👼🏼 sorry...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's currently not really done that way but i changed my code respectively.


== OpenAPI: A Standard for API Description
OpenAPI, formerly known as Swagger, is a widely adopted standard for describing RESTful APIs. It provides a
language-agnostic interface to define the structure of APIs in a human-readable format, typically using YAML
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
language-agnostic interface to define the structure of APIs in a human-readable format, typically using YAML
language-agnostic interface to define the structure of APIs in a human- and at the same time machine-readable format, typically using YAML

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have embedded the documentation into the existing open api documentation. Therefore, I dont need this abstract any more. It has been removed.

Comment on lines 10 to 12
OpenAPI specifications are commonly used to generate various artifacts such as client libraries, server stubs, and
documentation. By capturing the structure and behavior of APIs in a machine-readable format, OpenAPI enables
seamless code generation, saving time and ensuring consistency across different implementations.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OpenAPI specifications are commonly used to generate various artifacts such as client libraries, server stubs, and
documentation. By capturing the structure and behavior of APIs in a machine-readable format, OpenAPI enables
seamless code generation, saving time and ensuring consistency across different implementations.

you've already said that imo.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

test-api-generator/citrus-test-api-generator-core/pom.xml Outdated Show resolved Hide resolved
test-api-generator/pom.xml Outdated Show resolved Hide resolved
test-api-generator/pom.xml Outdated Show resolved Hide resolved
@christophd christophd marked this pull request as draft May 17, 2024 06:59
@christophd
Copy link
Member

@tschlat awesome work! please bear with me as I need some more time to have a closer look

@tschlat tschlat force-pushed the issue/1156/test_api_generator_TS branch from 50a7341 to 0b59743 Compare May 21, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants