-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport GHA Migration to release-9.4 #7318
base: release-9.4
Are you sure you want to change the base?
Conversation
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com> (cherry picked from commit e0b0cdb)
Since GHA does not interpolate env variables in a matrix context, This PR defines them in a separate job and uses them in other jobs. (cherry picked from commit 2bf1472)
Making tasks in CI required before merging to master is important and useful. The way this works is by saving the exact names of the required tasks in the admin interface of the repo. It has a search box to add them so it's not completely horrible, but doing so is quite a hassle since we have so many jobs. So limiting the amount of churn in this list of required jobs is quite useful. This changes the names of tasks to only include the major versions of Postgres, not the minor ones. Otherwise the next time we bump the minor versions we would have to remove and re-add each of the jobs. (cherry picked from commit 83e3fb8)
We are switching to Github Actions. In the test period it has worked well enough, so now we can stop using CircleCI. (cherry picked from commit ce58c04)
(cherry picked from commit 344bc5b)
(cherry picked from commit ec531c4)
(cherry picked from commit d69fe36)
(cherry picked from commit 512d185)
(cherry picked from commit 5d7924e)
(cherry picked from commit 3eb4f47)
(cherry picked from commit 9e0fee9)
Codecov Report
@@ Coverage Diff @@
## release-9.4 #7318 +/- ##
===============================================
- Coverage 91.48% 87.56% -3.93%
===============================================
Files 188 188
Lines 37707 37758 +51
Branches 0 4917 +4917
===============================================
- Hits 34497 33062 -1435
- Misses 3210 3232 +22
- Partials 0 1464 +1464 |
997cfe6
to
7056e22
Compare
7056e22
to
404ca61
Compare
chown -R circleci . | ||
git config --global --add safe.directory ${GITHUB_WORKSPACE} | ||
PG_CONFIG=/usr/lib/postgresql/${{ inputs.pg_major }} >>/bin/pg_config | ||
gosu circleci ./configure --without-pg-version-check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like --without-pg-version-check
is unrecognized from CI outputs.
matrix: | ||
include: | ||
- old_pg_major: 11 | ||
new_pg_major: 12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI complains about Citus version is not supported for Postgres 13. It seems to me like we have PG_MAJOR=13 at image and we could not override that from CI.
DESCRIPTION: PR description that will go into the change log, up to 78 characters