Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redux dependency #13

Merged
merged 2 commits into from Apr 10, 2018
Merged

Update redux dependency #13

merged 2 commits into from Apr 10, 2018

Conversation

chrisdakin
Copy link
Contributor

Updates redux dependency to beta version. This is necessary for react-redux to support lifecycle methods introduced in react 16.3 [Link]

Note: As soon as redux releases a stable v4.0 we'll want to update again, and for now release this is a beta version.

Updates redux dependency to 4.0.0-beta.2
mdarens
mdarens previously approved these changes Apr 6, 2018
@chrisdakin chrisdakin self-assigned this Apr 9, 2018
package.json Outdated
@@ -30,7 +30,7 @@
"seamless-immutable": "6.x"
},
"peerDependencies": {
"redux": "3.x"
"redux": "4.0.0-beta.2"
Copy link
Contributor

@chadly chadly Apr 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just do >= 3.x < 5 here? Will that allow consuming clients to pull in 4.0.0-beta.2? I would think so.

@chadly chadly merged commit 5ffe815 into master Apr 10, 2018
@chadly chadly deleted the redux-dependency branch April 10, 2018 21:33
@chadly
Copy link
Contributor

chadly commented Apr 10, 2018

Published as v4.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants