Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor authentication code #2027

Merged
merged 22 commits into from Mar 25, 2022
Merged

Refactor authentication code #2027

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
8823d19
Begin refactoring authentication code
zaralouis-sf Mar 3, 2022
ad591ea
Refactoring auth code
zaralouis-sf Mar 7, 2022
4e9da49
formatting fixes
zaralouis-sf Mar 7, 2022
9df693a
fix security module
zaralouis-sf Mar 8, 2022
a715e11
Fix broken browser test
zaralouis-sf Mar 8, 2022
8b5a51b
Try to fix injection
zaralouis-sf Mar 8, 2022
093bae1
Removing unnecessary annotations
zaralouis-sf Mar 8, 2022
475b102
Change bound client type
zaralouis-sf Mar 8, 2022
cd7161c
Revrese changes
zaralouis-sf Mar 8, 2022
393fb42
Fix one line
zaralouis-sf Mar 8, 2022
d1e2446
Add nullable annotation
zaralouis-sf Mar 8, 2022
d7ea60b
Default config options
zaralouis-sf Mar 8, 2022
9ab3473
universal-application-tool-0.0.1/app/controllers/LoginController.java
zaralouis-sf Mar 8, 2022
57d1901
Formatting
zaralouis-sf Mar 8, 2022
5c6b52a
Add null checks
zaralouis-sf Mar 8, 2022
faf128c
Responding to PR comments
zaralouis-sf Mar 9, 2022
9a6c4b1
Responding to PR comments
zaralouis-sf Mar 10, 2022
478cdb5
Respond to more PR comments
zaralouis-sf Mar 10, 2022
f3457f9
Re add comment
zaralouis-sf Mar 10, 2022
704187b
Responding to more PR comments
zaralouis-sf Mar 18, 2022
10e68e1
Add legacy routes handler
zaralouis-sf Mar 22, 2022
34ff231
Update LegacyRoutesController
zaralouis-sf Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions universal-application-tool-0.0.1/app/controllers/LegacyRoutesController.java
View file
Open in desktop
@@ -1,5 +1,7 @@
package controllers;

import static play.mvc.Results.redirect;

import java.util.Optional;
import play.mvc.Http;
import play.mvc.Result;
Expand All @@ -11,14 +13,14 @@
public class LegacyRoutesController {

public Result idcsLoginWithRedirect(Http.Request request, Optional<String> redirectTo) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the request be used in the body? I see it's dropped here. Is the intent to always redirect to the new handler rather than handle the old route through new refactored flow?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, I think the redirect method used automatically passes in the request context. Here's the docs on it: https://www.playframework.com/documentation/2.8.x/JavaRouting#Reverse-routing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes Shubha that was my understanding as well! Thanks for the docs! I can add them as a comment if you think it would be helpful Shane?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! thanks yall!

return routes.LoginController.applicantLogin(redirectTo);
return redirect(routes.LoginController.applicantLogin(redirectTo));
}

public Result adfsLogin(Http.Request request) {
return routes.LoginController.adminLogin();
return redirect(routes.LoginController.adminLogin());
}

public Result loginRadiusLoginWithRedirect(Http.Request request, Optional<String> redirectTo) {
return routes.LoginController.applicantLogin(redirectTo);
return redirect(routes.LoginController.applicantLogin(redirectTo));
}
}