Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Bitwarden Passwordless.dev app to marketplace #759

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

keithhubner
Copy link
Contributor

Thank you for wanting to submit a Pull Request to the Civo Kubernetes Marketplace repository!

If your pull request is to submit a new application to the marketplace, please answer the following questions:

  • Have you followed the guidelines in our Contributing document in setting up the application?
  • Have you checked that the application your submission is proposing to add does not yet exist on the Marketplace, or as a pull request to be processed?
  • Have you tested your application on the Civo managed Kubernetes service? Please include a screenshot.
  • Can you confirm that the software you are submitting licensed for use in a publicly-available Kubernetes marketplace?
  • Have you included the specific version of the application to be installed?

If your pull request concerns an existing Marketplace application, please make sure you have:

  • Notified the Maintainer of the application in this pull request so that they are aware of your proposal.
  • Outlined the changes you are proposing, and the reasons these are required (e.g. stability, compatibility with new versions of Kubernetes implementations, etc).
  • Tested that the application works with the proposed updates applied (including a screenshot).
  • Updated the version number of the app if that has changed.

@saiyam1814
Copy link
Contributor

@keithhubner the pre_install is not working currently @vishalanarase is working on the fix. TIll that if can find any other alternative, I would be happy to merge. Till then even if I merge, it wont work.

@kunal-kushwaha
Copy link
Member

@vishalanarase do you have any updates on the fix?

@vishalanarase
Copy link
Member

@kunal-kushwaha It's been merged and existing apps with pre_install.sh are working.

@keithhubner
Copy link
Contributor Author

Is this in the marketplace yet?

@vishalanarase
Copy link
Member

Is this in the marketplace yet?

No, did you tested this app in the civo-kubernetes cluster?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants