Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rqlite automatic pr's via updatecli #765

Merged
merged 4 commits into from May 14, 2024

Conversation

NerdyShawn
Copy link
Contributor

@NerdyShawn NerdyShawn commented May 7, 2024

Thank you for wanting to submit a Pull Request to the Civo Kubernetes Marketplace repository!

If your pull request is to submit a new application to the marketplace, please answer the following questions:

  • Have you followed the guidelines in our Contributing document in setting up the application?
  • Have you checked that the application your submission is proposing to add does not yet exist on the Marketplace, or as a pull request to be processed?
  • Have you tested your application on the Civo managed Kubernetes service? Please include a screenshot.
  • Can you confirm that the software you are submitting licensed for use in a publicly-available Kubernetes marketplace?
  • Have you included the specific version of the application to be installed?

If your pull request concerns an existing Marketplace application, please make sure you have:

  • Notified the Maintainer of the application in this pull request so that they are aware of your proposal.
  • Outlined the changes you are proposing, and the reasons these are required (e.g. stability, compatibility with new versions of Kubernetes implementations, etc).
  • Tested that the application works with the proposed updates applied (including a screenshot).
  • Updated the version number of the app if that has changed.

@NerdyShawn
Copy link
Contributor Author

The dry-run seems fine

⚠ deps: bump rqlite version:
	Source:
		✔ [app] Get latest rqlite version
		✔ [chart] Get latest rqlite Helm Chart version
	Target:
		✔ [install] Update rqlite/install.sh
		✔ [manifest] Update rqlite/manifest.yaml


Run Summary
===========
Pipeline(s) run:
  * Changed:	1
  * Failed:	0
  * Skipped:	0
  * Succeeded:	18
  * Total:	19

but when I applied my targets step is failing, and I checked pat token permissions.

TARGETS
========

install
-------- all contents from 'file' and 'files' combined already up to dateWhile nothing change in the current pipeline run, according to the git history, some commits must be pushed
ERROR: non-fast-forward update
ERROR: push error: authorization failed

manifest
--------- no change detected:
	* key "$.version" already set to "8.24.2", from file "rqlite/manifest.yaml"While nothing change in the current pipeline run, according to the git history, some commits must be pushed
ERROR: non-fast-forward update
ERROR: push error: authorization failed

ERROR: something went wrong in target "install" : "authorization failed"
ERROR: something went wrong in target "manifest" : "authorization failed"

Pipeline "deps: bump rqlite version" failed
Skipping due to:
	targets stage:	"something went wrong during target execution"


ACTIONS
========

ERROR: 2 target(s) (manifest,install) failed for action "kubernetes-marketplace"
Existing GitHub pull request found: https://github.com/civo/kubernetes-marketplace/pull/746
Existing GitHub pull request found: https://github.com/civo/kubernetes-marketplace/pull/748
Existing GitHub pull request found: https://github.com/civo/kubernetes-marketplace/pull/747
Existing GitHub pull request found: https://github.com/civo/kubernetes-marketplace/pull/754
Existing GitHub pull request found: https://github.com/civo/kubernetes-marketplace/pull/764
Existing GitHub pull request found: https://github.com/civo/kubernetes-marketplace/pull/745
Existing GitHub pull request found: https://github.com/civo/kubernetes-marketplace/pull/755
Existing GitHub pull request found: https://github.com/civo/kubernetes-marketplace/pull/760
Existing GitHub pull request found: https://github.com/civo/kubernetes-marketplace/pull/756
Existing GitHub pull request found: https://github.com/civo/kubernetes-marketplace/pull/753



Run Summary
===========
Pipeline(s) run:
  * Changed:	0
  * Failed:	1
  * Skipped:	0
  * Succeeded:	18
  * Total:	19
ERROR: ✗ 1 over 19 pipeline failed
ERROR: command failed: 1 over 19 pipeline failed

@NerdyShawn NerdyShawn marked this pull request as ready for review May 7, 2024 03:30
@olblak
Copy link
Contributor

olblak commented May 12, 2024

@NerdyShawn Your pullrequest sounds good to me even thought I didn't tested but you can target your own repository by updating

(locally)

And then running from your machine

updatecli diff --config .github/updatecli/updatecli.d/rqlite.yaml --values .github/updatecli/values.d/scm.yaml

@NerdyShawn
Copy link
Contributor Author

Nice, thanks for the example to target an individual app like this. I did change the org and set my token's right and verified against my repo that it is making PR's ok so got confidence now in the merge.

Run Summary
===========
Pipeline(s) run:
  * Changed:	13
  * Failed:	0
  * Skipped:	0
  * Succeeded:	6
  * Total:	19

opened 13 pr's ok
Thanks for the help and giving me and mentioning targeting the one app is a bit more helpful too, plus quicker than running through the current 19 of them.
image

@NerdyShawn NerdyShawn changed the title rqlite controlled via updatecli rqlite automatic pr's via updatecli May 12, 2024
Copy link
Member

@kunal-kushwaha kunal-kushwaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kunal-kushwaha kunal-kushwaha merged commit 083a990 into civo:master May 14, 2024
@NerdyShawn NerdyShawn deleted the addRqliteUpdatecli branch May 14, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants