Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dev dependencies #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

borracciaBlu
Copy link

No description provided.

@borracciaBlu
Copy link
Author

borracciaBlu commented Dec 17, 2019

on npm audit:

found 9 vulnerabilities (2 low, 2 moderate, 4 high, 1 critical)

these apparently are related to marshmallow and inject-ga.

I see that these two package are not strictly related to the package and are used only on deploy:

"deploy": "marshmallow -o docs -i artwork.psd -f -m && inject-ga docs/index.html -o docs/index.html -c 'UA-24389952-13' && boeing docs && rimraf docs",

If i may, i would suggest to remove the two packages and in deploy use instead npx:

"deploy": "npx marshmallow -o docs -i artwork.psd -f -m && npx inject-ga docs/index.html -o docs/index.html -c 'UA-24389952-13' && npx boeing docs && rimraf docs",

@borracciaBlu
Copy link
Author

In here i got a working prototype
borracciaBlu/banner-cli@aed3ea8

additional benefit of npx you don't have to keep update these packages all the times because npx is going to use the latest version

@github-staff github-staff deleted a comment from apocanow1 Apr 11, 2024
@github-staff github-staff deleted a comment Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant