Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Button "Sign In with GitHub to agree" causes confusion #1033

Open
srl295 opened this issue Dec 18, 2023 · 0 comments
Open

ui: Button "Sign In with GitHub to agree" causes confusion #1033

srl295 opened this issue Dec 18, 2023 · 0 comments

Comments

@srl295
Copy link

srl295 commented Dec 18, 2023

URL to the linked Repository or Organization

  • any

Steps to reproduce the problem

  • attempt to sign a CLA with metadata (custom fields)

What is the expected result?

  • I would expect the custom fields to show up even before the user signs in, so they know what will be expected.
  • I would expect the user would know they must login BEFORE they sign the CLA

What happens instead?

  • only the "I accept … privacy policy" message shows up.
  • The button "Sign In with GitHub to agree" makes users think that clicking that button actually signs the CLA

Any other information? (attach screenshot if possible)

image

but once you click that button:

image

Used browser and browser version?

any
srl295 added a commit to srl295/cla-assistant that referenced this issue Dec 18, 2023
@srl295
fix: Update cla.html to clarify signin flow
8bdb656 
- Change "agree" to "continue" for buttons that won't actually agree but require sign-in
- Change "Sign-in" to "login" to avoid confusion with "signing a CLA"
- Hide the privacy checkbox if there are custom fields AND the user isn't signed in
- for: cla-assistant#1033
@srl295 srl295 mentioned this issue Dec 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@srl295