fix: Update cla.html to clarify signin flow #1034
Conversation
- Change "agree" to "continue" for buttons that won't actually agree but require sign-in - Change "Sign-in" to "login" to avoid confusion with "signing a CLA" - Hide the privacy checkbox if there are custom fields AND the user isn't signed in - for: cla-assistant#1033
|
|
|
|
| <label ng-class="required" ng-show="linkedItem.privacyPolicy && (!hasCustomFields || user.value)"> | ||
| <input ng-disabled="signed" ng-model="privacyPolicyAccepted" type="checkbox" /> I accept that the information I provide to sign this CLA will be maintained in accordance with project | ||
| owner's | ||
| <a class="highlighted-link" ng-href="{{linkedItem.privacyPolicy}}" target="space">privacy policy</a> * | ||
| </label> |
There was a problem hiding this comment.
Don't show this checkbox unless there are no custom fields OR if the user's signed in. Otherwise, they'll just have to click it again.
| <input ng-disabled="signed" ng-model="privacyPolicyAccepted" type="checkbox" /> I accept that the information I provide to sign this CLA will be maintained in accordance with project | ||
| owner's | ||
| <a class="highlighted-link" ng-href="{{linkedItem.privacyPolicy}}" target="space">privacy policy</a> * | ||
| </label> | ||
| <form class="row" ng-if="hasCustomFields"> | ||
| <p> | ||
| <button class="btn btn-info btn-lg" ng-show="hasCustomFields && !signed && linkedItem && claText && !user.value" ng-click="signIn()">Sign in with GitHub to agree</button> | ||
| <button class="btn btn-info btn-lg" ng-show="hasCustomFields && !signed && linkedItem && claText && !user.value" ng-click="signIn()">Login with GitHub to continue</button> |
There was a problem hiding this comment.
This is the major change. Clicking this button does not agree, it just signs you in so you can see the custom fields, and enables the real "I agree" button.
There was a problem hiding this comment.
I agree that this change (changing "to agree" to "to continue") fixes the part that I found confusing.
| @@ -36,8 +36,8 @@ <h4>{{titleMsg()}}</h4> | |||
| </form> | |||
| <p class="row" ng-hide="signed"> | |||
| <button class="btn btn-info btn-lg" ng-show="hasCustomFields && !signed && linkedItem && claText && user.value" ng-disabled="(hasCustomFields && !isValid()) || (linkedItem.privacyPolicy && !privacyPolicyAccepted)" | |||
| ng-click="agree()">I agree</button> | |||
| <button class="btn btn-info btn-lg" ng-show="!hasCustomFields && !signed && linkedItem && claText" ng-click="agree()">Sign in with GitHub to agree</button> | |||
| ng-click="agree()">I Agree</button> | |||
There was a problem hiding this comment.
This is the real "I agree" button when there are custom fields.
| ng-click="agree()">I agree</button> | ||
| <button class="btn btn-info btn-lg" ng-show="!hasCustomFields && !signed && linkedItem && claText" ng-click="agree()">Sign in with GitHub to agree</button> | ||
| ng-click="agree()">I Agree</button> | ||
| <button class="btn btn-info btn-lg" ng-show="!hasCustomFields && !signed && linkedItem && claText" ng-click="agree()">Login with GitHub to agree</button> |
There was a problem hiding this comment.
This is the "I agree" button when there are NO custom fields.
Is it signed or not? :) |
seems signed… |
|
Anyone able to look at this? This flow has confused our users. |
fyi @annebright @markusicu @sffc @dbaron