fix!: Simplify min_values/max_values into number_of_values (per occurrence) #4001
+709
−343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the downside of a regression in `--help`. We expect to fix that soon-ish.
Making sure we cover the expected experience from multiple perspectives
Before we did 0..=1 across all occurrences when what we really wanted was 0..=1 per occurrence. This makes it compatible with `ArgAction::Append`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
min_values/max_valuesare across all occurrences--flag [value]behavior with multiple occurrencesnumber_of_valuesis sort of per occurrence on averagemultiple_valuesandtakes_valueThis is a major steps towards simplifying all of that (#2688) by creating
number_of_values(range).Still remaining is to look into dropping
multiple_valuesandtakes_valuein favor of this.